Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GrpcError when failing to connect on read #111

Open
tebeka opened this issue Nov 28, 2018 · 1 comment
Open

GrpcError when failing to connect on read #111

tebeka opened this issue Nov 28, 2018 · 1 comment
Assignees
@tebeka

Comments

@tebeka
Copy link
Contributor

tebeka commented Nov 28, 2018

When trying to read and there's no connection, a GrpcError is raised instead of a ReadError.
@tebeka tebeka self-assigned this Nov 28, 2018
@tebeka
Copy link
Contributor Author

tebeka commented Nov 28, 2018

The issue is that read returns a generator, making the grpc_raise decrorator ineffective.
We probably need to check in grpc_raise if the return value is a generator and yield from it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tebeka tebeka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tebeka