Overriding of ValidationResult for a nonParsableValue in DatePicker.checkValidity() not possible

[SonReimer]

Description

I wanted to set an explicit error message to the ValidationResult.error(String) method in DatePicker.checkValidity(), but that is seems to be nearly not possible, because I had to overwrite the following methods:

  @Override
  public Validator<LocalDate> getDefaultValidator() {
      if (isFeatureFlagEnabled(FeatureFlags.ENFORCE_FIELD_VALIDATION)) {
          return (value, context) -> checkValidity(value);
      }

      return Validator.alwaysPass();
  }

  private ValidationResult checkValidity(LocalDate value) {
      if (isFeatureFlagEnabled(FeatureFlags.ENFORCE_FIELD_VALIDATION)) {
          boolean hasNonParsableValue = value == getEmptyValue()
                  && isInputValuePresent();
          if (hasNonParsableValue) {
              return ValidationResult.error(getResourceString("date.parse.error.message", getLabel()));
          }
      }

      var greaterThanMax = ValidationUtil.checkGreaterThanMax(value, getMax());
      if (greaterThanMax.isError()) {
          return greaterThanMax;
      }

      var smallerThanMin = ValidationUtil.checkSmallerThanMin(value, getMin());
      if (smallerThanMin.isError()) {
          return smallerThanMin;
      }

      return ValidationResult.ok();
  }
  
  @Synchronize(property = "_hasInputValue", value = "has-input-value-changed")
  private boolean isInputValuePresent() {
      return getElement().getProperty("_hasInputValue", false);
  }

I think setting the ValidationResult for hasNonParsableValue=true should be extracted to a protected method like

protected String getNonParsableValueErrorMessage() {
  return ""
}

Environment

Vaadin 23.3.0.beta2

[SonReimer]

I think this issue may apply to other components like TimePicker DateTimePicker, BigDecimalField etc. as well.

[knoobie]

Similar suggestion in the initial addition of the "feature": #3406 (comment)

[yuriy-fix]

The feature is not yet implemented, but we are currently investigating the ways of adding that one.

[SonReimer]

What's the status of this issue ?

[SonReimer]

Any idea, when this will be implemented ?

[vursen]

I'm closing the issue because we now have a dedicated ticket (#4618) specifically for the configuration of constraint error messages. Please, follow that ticket for further updates.