Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V24.4 alpha 22 testing: "ConfirmDialog" component should not add unsupported methods #5243

Open
Tracked by #5012
bennewi opened this issue Apr 17, 2024 · 6 comments
Open
Tracked by #5012
Labels

Comments

@bennewi
Copy link

bennewi commented Apr 17, 2024

Describe the bug

A number of methods were added to the ConfirmDialog component in V24.4 that are marked as "Deprecated, not supported since 24.4"

This creates an ambiguous and confusing situation.

Expected-behavior

Better to either add the methods and support them or don't add the methods.

Reproduction

(seen in api docs)

System Info

(seen in api docs)

@bennewi bennewi added the bug label Apr 17, 2024
@TatuLund
Copy link
Contributor

Those do not look like new methods, but inherited methods, which use can break intended use of ConfirmDialog. Hence I think deprecation is a good way to warn about them.

@bennewi
Copy link
Author

bennewi commented Apr 17, 2024

formal java api docs could make that clear. This doesn't have to block beta

@web-padawan
Copy link
Member

The change is intentional. See vaadin/flow-components#5519 where it was implemented.

@bennewi
Copy link
Author

bennewi commented Apr 17, 2024

I understand, but anyone reading java api docs won't get the explanation. Would be better to add because it looks rather strange at the moment.

@manolo
Copy link
Member

manolo commented May 16, 2024

@web-padawan So what is needed for closing this issue? add some explanation in javadocs?

@web-padawan
Copy link
Member

Yes, we probably could clarify Javadoc (although it already describes why these methods are unsupported).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants