Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Desktop Button: Hidden (Not working) #4020

Open
rEd2k opened this issue Dec 9, 2024 · 6 comments
Open

Show Desktop Button: Hidden (Not working) #4020

rEd2k opened this issue Dec 9, 2024 · 6 comments

Comments

@rEd2k
Copy link

rEd2k commented Dec 9, 2024

Windows Ver. 26100.2454

In the system tray option I can only get the "Show Desktop Button: Enabled (default)" or "Show Desktop Button: Disabled" to work. The hidden option doesn't seem to do anything and the show desktop button area (although small) is still visible. Not a huge issue, just missing that functionality.

Did full reinstall of explorerpatcher and yes I am using the "Windows 10 (Explorer Patcher)" option under "taskbar style" if that matters for the system tray.

Any help or update on a fix would be great, thank you.

@pyrates999
Copy link

Please show a screen shot of what you mean.

@rEd2k
Copy link
Author

rEd2k commented Dec 9, 2024

Please show a screen shot of what you mean.

Really? ok then. The pic with the green line/arrow shows what "enabled (default)" looks like with a thin light colored line to the bottom right (I didn't have the mouse highlight the area), and the blue line/arrow shows what the "disabled" option looks like where there is no "show desktop" button present, and finally, the red line/arrow shows the "hidden" option selected. Unfortunately, as one can clearly see, the "show desktop" button is still present and visible when the intent is to have the button usable but in an invisible state as it used to be when it was a functional feature.

Enabled2
Disabled2
Hidden2

@Amrsatrio
Copy link
Collaborator

Will fix it in the next EP release.

@rEd2k
Copy link
Author

rEd2k commented Dec 10, 2024

Will fix it in the next EP release.

Great to hear this! Thank you for the attention to this small, but very useful option. I am an OLED user and any way to remove static pixels from the screen is a bonus for users like myself that don't want burn in on a $5k TV over time. Thank you kindly to the explorerpatcher team, and keep up the great work!

@Amrsatrio
Copy link
Collaborator

Don't worry, almost everything bugged in ep_taskbar can be fixed easily.

Amrsatrio added a commit to Amrsatrio/ExplorerPatcher that referenced this issue Dec 10, 2024
- Invisible mode (2) now supports ep_taskbar. We do this by completely overriding WM_PAINT and WM_PRINTCLIENT when this mode is active, instead of null-ing the HTHEME.
- Disabled mode (1) now hides the window instead of returning 0 (width/height value depending on taskbar orientation) in message 0x464 (calculate minimum size). Fortunately CTrayNotify handles the visibility of the button, therefore this also fixes tab navigation when the button is hidden.
Amrsatrio added a commit that referenced this issue Dec 10, 2024
- Invisible mode (2) now supports ep_taskbar. We do this by completely overriding WM_PAINT and WM_PRINTCLIENT when this mode is active, instead of null-ing the HTHEME.
- Disabled mode (1) now hides the window instead of returning 0 (width/height value depending on taskbar orientation) in message 0x464 (calculate minimum size). Fortunately CTrayNotify handles the visibility of the button, therefore this also fixes tab navigation when the button is hidden.
@Amrsatrio
Copy link
Collaborator

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants