Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error is not cleared after a change without error #30

Open
bruno-olivia opened this issue Apr 3, 2020 · 1 comment
Open

Error is not cleared after a change without error #30

bruno-olivia opened this issue Apr 3, 2020 · 1 comment

Comments

@bruno-olivia
Copy link

Please, clear the variable this.err at the function handleChange before the line:

this.props.onChange(currentJson);

With it, I can just check the err variable at the editor to check if there is an error at the JSON

@seanmalbert
Copy link

This fix would be great. Since it doesn't clear, we can't reliably check this.err, and I would like to prevent saving in our app if there was still a valid error. If a PR would help speed this up, please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants