Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

Support SNI for HTTPClient #313

Open
mura-admin opened this issue Oct 15, 2018 · 3 comments
Open

Support SNI for HTTPClient #313

mura-admin opened this issue Oct 15, 2018 · 3 comments
Labels
enhancement New feature or request

Comments

@mura-admin
Copy link
Contributor

Currently any host that requires SNI will currently fail on TLS negotiation. i.e. most hosts that are behind Cloudflare: https://support.cloudflare.com/hc/en-us/articles/204144518-SSL-FAQ

Given that a large part of the web is now behind shared protected edge services this seems like a much needed feature.

Will submit a pull request with my solution.

@jdmcd
Copy link
Member

jdmcd commented Oct 15, 2018

Hi @mura-admin! Could you please clarify where in the chain of events this happens? I have numerous Vapor hosts behind Cloudflare utilizing SNI certs and I've never encountered any problems with direct web connections to those hosts or inter-host communication. Just want to better wrap my head around what you're describing :)

@mura-admin
Copy link
Contributor Author

I'm referring specifically to HTTPClient.connect and HTTPClient.upgrade in this codebase. Accessing from a browser isn't an issue as SNI is supported in all modern browsers.

I've just finished a pull request there so will post it now.

@jdmcd
Copy link
Member

jdmcd commented Oct 15, 2018

Awesome! Thanks for your work on this.

@mura-admin mura-admin mentioned this issue Oct 15, 2018
@mura-admin mura-admin changed the title Support for SNI Support SNI for HTTPClient Oct 15, 2018
@tanner0101 tanner0101 added the enhancement New feature or request label Oct 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants