Enhancement Request: NFS4.1 support from WebGui

[MrMEEE]

Hi..

I have just gotten NFS4.1 support merged upstream and in XCP-NG..

Right now there is only an option for NFS4 in the webinterface.. can we add an option for NFS4.1 as well??

[ghost]

Doesn't it work to add vers=4.1 mount option?

[MrMEEE]

I could add it to the nfs options field, but that will actually add both vers=4 and vers=4.1, looking at the code of nfs.py (XCP/Xenserver)

I think we need a extra tick button with 4.1 or maybe a dropdown...

[julien-f]

We need to change the current toggle by a select which would allow choosing between NFS default, 4 and 4.1.

[stormi]

And ideally detect if the options field contains nfsversion=something to let users override the value with their own (if that's not already the case).

[GHEMID-Mohamed]

@julien-f it would be better if we can get Nfs versions (3, 4, 4.1) from probeSrNfs()

[julien-f]

@julien-f it would be better if we can get Nfs versions (3, 4, 4.1) from probeSrNfs()

I have no idea how it works.

[ghost]

Why not allow 4.2?

[stormi]

Because CH 8.0 and XCP-ng 8.0 don't support it yet

[julien-f]

@stormi What happen if we ask for a non supported version?

[stormi]

Then the mount command will most certainly fail

[stormi]

Hmm, you meant, not supported by the CH or XCP-ng host. Well, I think it will say that it's not supported.

[stormi]

See https://github.com/xapi-project/sm/pull/424/files#diff-2b603de70ea741f9ad883d690b55f968R114

[julien-f]

Thanks.

[stormi]

And ideally detect if the options field contains nfsversion=something to let users override the value with their own (if that's not already the case).

I though nfsversion was a supported option in the field, because I thought the options field was options for XAPI, not for mount. Since those are options for mount, then forget about this detection of overridden version by the user.

[ghost]

Isn't it in the kernel? What does the following say ?
#cat /proc/fs/nfsd/versions

[stormi]

Isn't it in the kernel? What does the following say ?
#cat /proc/fs/nfsd/versions

It is in the kernel, but the list of supported versions is hardcoded in sm so we need to have it added upstream (see above commit reference, the same must be done for 4.2). Feel free to open a pull request to https://github.com/xapi-project/sm and create an issue for XCP-ng at https://github.com/xcp-ng/xcp/issues for inclusion in XCP-ng.

[ghost]

I had a quick look. Not familiar with the coding, but it seems that the rpcinfo -p binary used to check supported version only check for major, not minor versions of the nfs protocol. Nfs 4.0, 4.1 and 4.2 all show as "4" with rpcinfo.

xapi-project/sm#446