From eeb67747268dea9cf02c7fe21cd1c3f80803099f Mon Sep 17 00:00:00 2001 From: Miguel Angel Rojo Date: Thu, 13 Feb 2025 16:42:19 +0000 Subject: [PATCH] removed unused method signal (#976) --- co/signal.go | 16 +--------------- co/signal_test.go | 18 ++---------------- 2 files changed, 3 insertions(+), 31 deletions(-) diff --git a/co/signal.go b/co/signal.go index 44957820d..d1b066169 100644 --- a/co/signal.go +++ b/co/signal.go @@ -10,13 +10,12 @@ import ( ) // Waiter provides channel to wait for. -// Value read from channel indicates signal or broadcast. true for signal, otherwise broadcast. type Waiter interface { C() <-chan bool } // Signal a rendezvous point for goroutines waiting for or announcing the occurrence of an event. -// It's more friendly than sync.Cond, since it's channel base. That means you can do channel selection +// It's more friendly than sync.Cond, since it's channel based. That means you can do channel selection // to wait for an event. type Signal struct { l sync.Mutex @@ -29,19 +28,6 @@ func (s *Signal) init() { } } -// Signal wakes one goroutine that is waiting on s. -func (s *Signal) Signal() { - s.l.Lock() - - s.init() - select { - case s.ch <- true: - default: - } - - s.l.Unlock() -} - // Broadcast wakes all goroutines that are waiting on s. func (s *Signal) Broadcast() { s.l.Lock() diff --git a/co/signal_test.go b/co/signal_test.go index b93c4c3b8..04a657c56 100644 --- a/co/signal_test.go +++ b/co/signal_test.go @@ -12,21 +12,7 @@ import ( "github.com/vechain/thor/v2/co" ) -func TestSignal_SignalBeforeWait(t *testing.T) { - var sig co.Signal - sig.Signal() - - <-sig.NewWaiter().C() -} - -func TestSignal_SignalAfterWait(t *testing.T) { - var sig co.Signal - w := sig.NewWaiter() - sig.Signal() - <-w.C() -} - -func TestSignal_BroadcastBefore(t *testing.T) { +func TestSignalBroadcastBefore(t *testing.T) { var sig co.Signal sig.Broadcast() @@ -46,7 +32,7 @@ func TestSignal_BroadcastBefore(t *testing.T) { assert.Equal(t, 10, n) } -func TestSignal_BroadcastAfterWait(t *testing.T) { +func TestSignalBroadcastAfterWait(t *testing.T) { var sig co.Signal var ws []co.Waiter