Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove ethers completly #47

Open
Agilulfo1820 opened this issue Jan 27, 2025 · 5 comments
Open

feat: remove ethers completly #47

Agilulfo1820 opened this issue Jan 27, 2025 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers wontfix This will not be worked on

Comments

@Agilulfo1820
Copy link
Member

We do not need ethers dependency, we can use sdk for current uses.

@Agilulfo1820 Agilulfo1820 added enhancement New feature or request good first issue Good for newcomers labels Jan 27, 2025
@victhorbi
Copy link
Collaborator

This will probably be the full migration to use VeChain-sdk v1.0.0. Right @fabiorigam ?

@Agilulfo1820
Copy link
Member Author

Actually I'm not sure we can 100% remove ethers, because it is used inside contracts/typechain-types

@fabiorigam
Copy link
Member

Exactly, I was analyzing it and it's not possible to completely remove ethers. Should we remote it where possible ot leave it as it is?

@victhorbi
Copy link
Collaborator

let's discuss during the standup, but we may want to at least migrate to viem. Let's try to be consistent across tools.

@Agilulfo1820
Copy link
Member Author

Yes @fabiorigam there is one place outside typechain data, let's remove it from there and use viem or sdk

@Agilulfo1820 Agilulfo1820 added the wontfix This will not be worked on label Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants