Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [BUG] - dappkit certifcicate signing #66

Open
Agilulfo1820 opened this issue Feb 3, 2025 · 0 comments
Open

🐛 [BUG] - dappkit certifcicate signing #66

Agilulfo1820 opened this issue Feb 3, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@Agilulfo1820
Copy link
Member

Description

The params passed to the DAppKit seems to do not have any effect, wheter I pass the requireCertificate=false, or setting a custom certificate signing it just does not have any effect and always requires a certificate with the same message.

Since when user is connected with Privy the certificate needs to be handled differently it would be better if this is handled internally (if privy then we sign message with a specific Type for typed data signing, if it's connected with dappkit then the usual dappkit signing).

Also if requireCertificate is set to true then when connected with privy we also need to ask for certificate.

Reproduction URL

No response

Reproduction steps

1. Try to change params to the provider of the app where you integrate the kit (you will see that it has no effect on dappkit)

Screenshots

Logs

OS

No response

@Agilulfo1820 Agilulfo1820 added the bug Something isn't working label Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant