From 4a44e41ac1929408a4142c63b6f10e17812be50e Mon Sep 17 00:00:00 2001 From: Devin Ford Date: Tue, 22 Oct 2024 10:54:56 -0400 Subject: [PATCH] fix(gh_action): Prevent workflow from triggering unless previous workflow succeeds (#21579) * fix: add conditional based on trigger success * chore: update trigger check * fix: add syncronize to trigger list * chore: debug * chore: remove debugging * fix: address feedback * fix: remove trailing space --- .github/workflows/build_preview_sites.yml | 4 +++- .github/workflows/preview_site_trigger.yml | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build_preview_sites.yml b/.github/workflows/build_preview_sites.yml index e3478ee2711d2..dd2a52302961f 100644 --- a/.github/workflows/build_preview_sites.yml +++ b/.github/workflows/build_preview_sites.yml @@ -8,6 +8,7 @@ on: jobs: deploy_vector_preview_site: + if: ${{ github.event.workflow_run.conclusion == 'success' && contains(github.event.workflow_run.head_branch, 'website') }} uses: ./.github/workflows/create_preview_sites.yml with: APP_ID: "d1a7j77663uxsc" @@ -18,6 +19,7 @@ jobs: ENDPOINT: ${{ secrets.BUILDER_ENDPOINT }} deploy_rust_doc_preview_site: + if: ${{ github.event.workflow_run.conclusion == 'success' && contains(github.event.workflow_run.head_branch, 'website') }} uses: ./.github/workflows/create_preview_sites.yml with: APP_ID: "d1hoyoksbulg25" @@ -28,6 +30,7 @@ jobs: ENDPOINT: ${{ secrets.BUILDER_ENDPOINT }} deploy_vrl_playground_preview_site: + if: ${{ github.event.workflow_run.conclusion == 'success' && contains(github.event.workflow_run.head_branch, 'website') }} uses: ./.github/workflows/create_preview_sites.yml with: APP_ID: "d2lr4eds605rpz" @@ -36,4 +39,3 @@ jobs: REQUEST_TOKEN: ${{ secrets.REQUEST_TOKEN }} REQUEST_MESSAGE: ${{ secrets.REQUEST_MESSAGE }} ENDPOINT: ${{ secrets.BUILDER_ENDPOINT }} - diff --git a/.github/workflows/preview_site_trigger.yml b/.github/workflows/preview_site_trigger.yml index 7c2a960e1f88d..3676a64554e03 100644 --- a/.github/workflows/preview_site_trigger.yml +++ b/.github/workflows/preview_site_trigger.yml @@ -2,7 +2,7 @@ name: Call Build Preview on: pull_request: - types: [opened, reopened] + types: [opened, reopened, synchronize] jobs: approval_check: