Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move back to upstream tokio #11257

Open
jszwedko opened this issue Feb 8, 2022 · 6 comments
Open

Move back to upstream tokio #11257

jszwedko opened this issue Feb 8, 2022 · 6 comments
Labels
domain: deps Anything related to Vector's dependencies type: task Generic non-code related tasks

Comments

@jszwedko
Copy link
Member

jszwedko commented Feb 8, 2022 •
edited
Loading

We had to fork Tokio in #13737 to revert a commit that changed the codec behavior. We should update our codecs to be compatible with the new Tokio codec behavior so we can switch back to upstream.
@jszwedko jszwedko added type: task Generic non-code related tasks domain: deps Anything related to Vector's dependencies labels Feb 8, 2022
This was referenced Feb 8, 2022
Closed
Closed
@StephenWakely
Copy link
Contributor

Just confirming this is still a problem with tokio-util 0.7.1.

@StephenWakely StephenWakely removed their assignment Jun 22, 2022
@pablosichert
Copy link
Contributor

Related upstream issue: tokio-rs/tokio#3976

@pablosichert pablosichert mentioned this issue Jul 27, 2022
Merged
@neuronull neuronull mentioned this issue Nov 28, 2022
Merged
@jszwedko jszwedko changed the title Upgrade tokio-util to >= 0.6.9 Move back to upstream tokio Dec 23, 2022
@jszwedko
Copy link
Member Author

Repurposing this to be to move back to upstream Tokio rather than maintaining our fork with the codec behavior patched.

@Xuanwo
Copy link
Contributor

Xuanwo commented Jul 25, 2023

Related upstream issue: tokio-rs/tokio#3976

Hi, @jszwedko. The upstream issue has been fixed. Is this problem still relevant?

I encountered this issue because one of the dependencies requires the use of tokio-util v0.7.8, which conflicts with the patched version of tokio-util.

@Xuanwo Xuanwo mentioned this issue Jul 25, 2023
Draft
@jszwedko jszwedko mentioned this issue Jul 25, 2023
Merged
jszwedko added a commit that referenced this issue Jul 25, 2023
@jszwedko
chore(deps): Update tokio-util fork to 0.7.8
3607a7e 
Prompted by #11257 (comment)

Signed-off-by: Jesse Szwedko <[email protected]>
@jszwedko
Copy link
Member Author

Hi @Xuanwo !

Unfortunately we still have to maintain the fork as we haven't worked around the new behavior in tokio-utils in Vector yet. I opened #18078 to bump the fork to the latest version though.

@Xuanwo
Copy link
Contributor

Xuanwo commented Jul 25, 2023

Hi @Xuanwo !

Unfortunately we still have to maintain the fork as we haven't worked around the new behavior in tokio-utils in Vector yet. I opened #18078 to bump the fork to the latest version though.

Thanks!

github-merge-queue bot pushed a commit that referenced this issue Jul 25, 2023
@jszwedko
chore(deps): Update tokio-util fork to 0.7.8 (#18078)
421b421 
Prompted by #11257 (comment)

Signed-off-by: Jesse Szwedko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
domain: deps Anything related to Vector's dependencies type: task Generic non-code related tasks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@StephenWakely @jszwedko @pablosichert @Xuanwo