Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial AWS EKS support #814

Closed
timberio-campfire opened this issue Aug 30, 2019 · 17 comments
Closed

Initial AWS EKS support #814

timberio-campfire opened this issue Aug 30, 2019 · 17 comments
Labels
domain: platforms Anything related to Vector's supported platforms have: should We should have this feature, but is not required. It is medium priority. needs: requirements Needs a a list of requirements before work can be begin platform: kubernetes Anything `kubernetes` platform related provider: aws Anything `aws` service provider related type: feature A value-adding code addition that introduce new functionality.

Comments

@timberio-campfire
Copy link

timberio-campfire commented Aug 30, 2019

We'd like to officially support Amazon's EKS platform.

  1. We should start with a specification to determine the best path forward.

  2. Its possible this might just wrap existing sources.

  3. Its possible this might just be an installation page in our documentation.

@timberio-campfire
Copy link
Author

@timberio-campfire timberio-campfire added type: new feature needs: requirements Needs a a list of requirements before work can be begin labels Aug 30, 2019
@LucioFranco
Copy link
Contributor

@binarylogic I think this makes sense, do we also want to open a more generic kube issue since I believe the implementation that will work for eks will work for any kube deployment?

@binarylogic
Copy link
Contributor

Yes, #260 handles that.

@binarylogic binarylogic added this to the Initial containers support milestone Sep 7, 2019
@ktff
Copy link
Contributor

ktff commented Sep 21, 2019

Current Kubernetes implementation in #893 was tested with AWS EKS ec2 cluster, and it works out of the box. Except of one bug found during testing.

So as @binarylogic said, this will be solved with #260. I anticipate that only retesting it on EKS will be needed.

@LucioFranco LucioFranco removed the needs: requirements Needs a a list of requirements before work can be begin label Oct 21, 2019
@LucioFranco
Copy link
Contributor

There is nothing to spec out here. Our current kube implementation covers this. What we will need is deployment guides around kube in general and these can be applied to EKS just like how you might apply it to any other kube cluster. Based on that I think this issue can be closed technically?

cc @binarylogic

@ktff
Copy link
Contributor

ktff commented Oct 22, 2019

I wouldn't close this issue until #1060 is implemented. The reason being that namespace information is necessary on EKS to properly filter out system logs. #893 on it's own isn't capable of doing that on EKS. Although, the number of system logs isn't large, it would still bother users.

@LucioFranco
Copy link
Contributor

@ktff I've updated #1060 to include that additional filter.

@Alexx-G
Copy link
Contributor

Alexx-G commented Apr 1, 2020

Is there anything Vector is missing for AWS EKS and it should be considering when deploying there? I've deployed it to AWS EKS (on managed worker nodes) and didn't notice any issues so far. However, it's still being validated in a staging environment.

@ktff
Copy link
Contributor

ktff commented Apr 3, 2020

@Alexx-G No, everything is in place, not only for EKS, but basically for any Kubernetes, with exception of Kubernetes backed by Windows nodes which they started recently supporting. But I would wait for 0.9 release as there is a breaking change in how Vector should be run, more specifically #2188.

Also this #1867 will change how the fields are named.

@Alexx-G
Copy link
Contributor

Alexx-G commented Apr 3, 2020

@ktff Thanks for details! I was expecting 0.9 to have breaking changes and there's a number of fixes I need, so this is fine.
Since #1888 has been merged, I suppose after 0.9 you don't expect any breaking changes (at least for event schema for kubernetes source)?

@binarylogic
Copy link
Contributor

@Alexx-G that's the goal. 0.10.0 is the "Kubernetes Release", where we will officially announce the integration. I don't foresee any major changes between 0.9.0 and 0.10.0, but we will also be rigorously QA'ing the integration during that time.

@binarylogic binarylogic assigned MOZGIII and unassigned ktff Apr 4, 2020
@binarylogic binarylogic added type: feature A value-adding code addition that introduce new functionality. and removed type: new feature labels Jun 16, 2020
@binarylogic binarylogic removed this from the Initial Containers Support milestone Jul 26, 2020
@MOZGIII
Copy link
Contributor

MOZGIII commented Aug 7, 2020

We should verify things work as expected before we consider this done.

@binarylogic binarylogic added domain: platforms Anything related to Vector's supported platforms platform: kubernetes Anything `kubernetes` platform related provider: aws Anything `aws` service provider related have: should We should have this feature, but is not required. It is medium priority. labels Aug 7, 2020
@binarylogic
Copy link
Contributor

Just clarifying the work here. We should verify and test this, possibly even add an integration test, but we should defer for it now. We have an epic to verify integration with a variety of hosted K8s platforms.

@binarylogic binarylogic removed their assignment Sep 24, 2020
@jamtur01 jamtur01 removed this from the 2020-09-14 - The Grid milestone Sep 28, 2020
@MOZGIII
Copy link
Contributor

MOZGIII commented Dec 17, 2020

I've started working is this. Apparently EKS integrations breaks in unexpected places (i.e. elasticsearch source), so I'll create issues to fix what I've found.

@Dragotic
Copy link

Hello, any news about the AWS EKS Support?

@jszwedko
Copy link
Member

Hi @Dragotic !

I think this may actually already be done since we do support deploying Vector to EKS. We have published Helm charts that make this easier. Is there anything in particular that you find missing though? We do have people successfully running Vector on EKS.

@jszwedko
Copy link
Member

I'll close this since we do have people running Vector on EKS, but we can open up follow-up issues if there is any support lacking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: platforms Anything related to Vector's supported platforms have: should We should have this feature, but is not required. It is medium priority. needs: requirements Needs a a list of requirements before work can be begin platform: kubernetes Anything `kubernetes` platform related provider: aws Anything `aws` service provider related type: feature A value-adding code addition that introduce new functionality.
Projects
None yet
Development

No branches or pull requests

9 participants