From 513c3cc69648d347711dcb37f73d77eb6da3db6a Mon Sep 17 00:00:00 2001 From: Jon Mease Date: Thu, 10 Aug 2023 13:07:04 -0400 Subject: [PATCH] dialect can be regular method --- python/vegafusion/vegafusion/dataset/duckdb.py | 3 +-- python/vegafusion/vegafusion/dataset/sql.py | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/python/vegafusion/vegafusion/dataset/duckdb.py b/python/vegafusion/vegafusion/dataset/duckdb.py index 5769fb5bb..3953dc915 100644 --- a/python/vegafusion/vegafusion/dataset/duckdb.py +++ b/python/vegafusion/vegafusion/dataset/duckdb.py @@ -7,8 +7,7 @@ class DuckDbDataset(SqlDataset): - @classmethod - def dialect(cls) -> str: + def dialect(self) -> str: return "duckdb" def __init__(self, relation: DuckDBPyRelation, fallback: bool = True, verbose: bool = False): diff --git a/python/vegafusion/vegafusion/dataset/sql.py b/python/vegafusion/vegafusion/dataset/sql.py index 81bb2edfa..e3936d85b 100644 --- a/python/vegafusion/vegafusion/dataset/sql.py +++ b/python/vegafusion/vegafusion/dataset/sql.py @@ -8,8 +8,7 @@ class SqlDataset(ABC): Python interface for VegaFusion Sql Dataset """ - @classmethod - def dialect(cls) -> str: + def dialect(self) -> str: """ Returns SQL dialect accepted by the connection