Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "copyright" header in all the pieces #51

Open
captbaritone opened this issue Aug 14, 2013 · 4 comments
Open

Add "copyright" header in all the pieces #51

captbaritone opened this issue Aug 14, 2013 · 4 comments
Assignees

Comments

@captbaritone
Copy link
Collaborator

From @veltzer's TODO file.

Probably the first step would be to create a test.

@captbaritone
Copy link
Collaborator Author

Just looked, and I think there is already a test for this but it's passing despite the fact that many tunes are missing copyright info.

@veltzer
Copy link
Owner

veltzer commented Aug 15, 2013

If a tune does not have a copyright I complete it by adding a "--- please help me to fill the copyright ---"
The idea is to find the right copyright (dig it from books, internet etc...).

@captbaritone
Copy link
Collaborator Author

Maybe we should create a test that checks for that string. It would
Be nice to have a way of listing which tunes need work without having to
check manually.

Another option might be to empty the string in the song files, and add the "---
please help me to fill the copyright ---" text automatically at render time.

On Wednesday, August 14, 2013, Mark Veltzer wrote:

If a tune does not have a copyright I complete it by adding a "--- please
help me to fill the copyright ---"
The idea is to find the right copyright (dig it from books, internet
etc...).


Reply to this email directly or view it on GitHubhttps://github.com//issues/51#issuecomment-22685636
.

-Jordan Eldredge

@veltzer
Copy link
Owner

veltzer commented Aug 15, 2013

Agreed.

@veltzer veltzer self-assigned this Nov 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants