Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back in double bar at end of song #68

Open
captbaritone opened this issue Aug 18, 2013 · 2 comments
Open

Add back in double bar at end of song #68

captbaritone opened this issue Aug 18, 2013 · 2 comments
Assignees

Comments

@captbaritone
Copy link
Collaborator

We disabled the double bar at the end of each section because it was breaking repeats at the end of sections, but we also removed the thick double-bar at the end of each song. Was this interfering with repeats at the end of songs?

If no, we should re-enable them because we need a thick double bar at the end of each tune, if yes, what are our other options?

Note: They were removed in commit e0133b4

@veltzer
Copy link
Owner

veltzer commented Aug 19, 2013

I removed it for the same reason, they were interfering with repeats.

We need to see if it's possible to have a macro that will put the think double bar ONLY IF there is no repeat. And then bring it back in...

@captbaritone
Copy link
Collaborator Author

Looking into this a little bit and I don't see any clean solutions. For the purpose of brainstorming, here are some possible solutions (each with their own drawbacks):

  1. Don't use wrapper function. Require the typesetter to specify the bars themselves
  2. Create wrapper functions for the possible combinations: \endPartRepeat, \endSongRepeat

I'm not familiar with mako templating. Would there be some way to use mako macros instead of lilypond's and have the behave differently depending on the context?

Let me know if you have any other ideas, or avenues worth looking down.

@veltzer veltzer self-assigned this Nov 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants