-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't deploy specific payment provider settings #15
Comments
Hi, easing back into uSync.Vendr with this one. :) So just to confirm what i am looking at ? In a "PaymentMethod" we have a provider settings section ? e.g for the 'Zero Value' payment methiod. <ProviderSettings>
<Setting>
<Key>ContinueUrl</Key>
<Value>/checkout/order-confirmation/</Value>
</Setting>
</ProviderSettings> presumably for more complex payment systems this is fancier and has more properties ? and we want to ignore/not serialize/deserialize certain ones? |
Yea, so those settings are always key/value, but in the app settings there should be something to say "ignore this setting entirely" and just don't include it. For example, here's what we now support in Vendr.Deploy
Which means any settings with the key
|
there is already have a way of passing settings to the serializers so the "simple" fix is to use that, but the settings will be buried in uSync then. "uSync": {
"Publisher": {
"Handlers": {
"vendrPaymentMethodHandler": {
"settings": {
"IgnoreSettings": [ "testMode", "sanboxMode", "liveApiKey" ]
}
}
}
}
} as much as that obviously pleases me, i think we can make a vendr.usync settings section for this one 😄 |
Hi this is already done on serialization 😄 I suppose for completeness, we could do in on import too, just incase its not configured on the exporting server. |
Ignore the settings by key on import, just covers situation where the values might have been exported but we don't want them imported.
Good point, I don't actually think we do that in Vendr.Deploy so I should probably implement that too 😁 |
This was raised in the Vendr Deploy repo but probably counts here too, but some payment provider settings might not want to be deployed so we have implemented an app setting to ignore specific settings. Whatever we do in that package, we are probably going to need to replicate here too
vendrhub/vendr-deploy#14
The text was updated successfully, but these errors were encountered: