From 7f31f2cc32b366a63971a1f1307bb383b3397f91 Mon Sep 17 00:00:00 2001 From: Tobias Koppers Date: Mon, 19 Aug 2024 13:22:34 +0200 Subject: [PATCH] no invalidation on Drop --- .../crates/turbo-tasks-fs/src/invalidator_map.rs | 13 ------------- turbopack/crates/turbo-tasks/src/state.rs | 9 --------- 2 files changed, 22 deletions(-) diff --git a/turbopack/crates/turbo-tasks-fs/src/invalidator_map.rs b/turbopack/crates/turbo-tasks-fs/src/invalidator_map.rs index 9ecaf6b1aee2e..7bb6b0d734ecf 100644 --- a/turbopack/crates/turbo-tasks-fs/src/invalidator_map.rs +++ b/turbopack/crates/turbo-tasks-fs/src/invalidator_map.rs @@ -71,16 +71,3 @@ impl<'de> Deserialize<'de> for InvalidatorMap { deserializer.deserialize_newtype_struct("InvalidatorMap", V) } } - -impl Drop for InvalidatorMap { - fn drop(&mut self) { - while let Ok((_, value)) = self.queue.pop() { - value.invalidate(); - } - for (_, invalidators) in self.map.lock().unwrap().drain() { - for invalidator in invalidators { - invalidator.invalidate(); - } - } - } -} diff --git a/turbopack/crates/turbo-tasks/src/state.rs b/turbopack/crates/turbo-tasks/src/state.rs index d2346ba103fe1..53552047e3d7a 100644 --- a/turbopack/crates/turbo-tasks/src/state.rs +++ b/turbopack/crates/turbo-tasks/src/state.rs @@ -68,15 +68,6 @@ impl<'de, T> Deserialize<'de> for State { } } -impl Drop for State { - fn drop(&mut self) { - let mut inner = self.inner.lock(); - for invalidator in take(&mut inner.invalidators) { - invalidator.invalidate(); - } - } -} - impl State { pub fn new(value: T) -> Self { mark_stateful();