Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl-C from Powershell is not resulting in underlying tasks being shut down #9730

Open
chris-olszewski opened this issue Jan 21, 2025 · 4 comments
Labels
area: windows Issues specifically reproducing on Windows kind: bug Something isn't working

Comments

@chris-olszewski
Copy link
Member

  • The output of turbo info:
turbo info
turbo 2.3.3

CLI:
   Version: 2.3.3
   Path to executable: ....\node_modules\turbo-windows-64\bin\turbo.exe
   Daemon status: Not running
   Package manager: berry

Platform:
   Architecture: x86_64
   Operating system: windows
   WSL: false
   Available memory (MB): 35060
   Available CPU cores: 24

Environment:
   CI: None
   Terminal (TERM): unknown
   Terminal program (TERM_PROGRAM): unknown
   Terminal program version (TERM_PROGRAM_VERSION): unknown
   Shell (SHELL): unknown
   stdin: false

Note that I'm running the command from a Windows Powershell terminal, but CMD has the same behavior too.

  • The command being used to invoke turbo: turbo run preview
  • How the signal is being sent to turbo: Ctrl+C on the terminal window

If it helps, below is the process hierarchy, see the dangling processes:

Image

Hope it helps @chris-olszewski

Originally posted by @erhan-talarian in #9694

@chris-olszewski chris-olszewski added kind: bug Something isn't working area: windows Issues specifically reproducing on Windows labels Jan 21, 2025
@chris-olszewski
Copy link
Member Author

@erhan-talarian I think I'm able to reproduce on my Windows machine. Just a few follow ups:

  • Can you confirm that you're using the streamed logs (--ui=stream)?
  • Do you get the same behavior if you don't use global turbo? e.g. yarn run preview (you will need a top level "preview": "turbo run preview" script)
  • Does Ctrl-C result in turbo exiting or do you need to end the process?

@erhan-talarian
Copy link

Hey @chris-olszewski

  • No, I'm using tui mode
  • Yes, the same behavior
  • turbo process exits, don't have to end it

@chris-olszewski
Copy link
Member Author

@erhan-talarian Could you show the process tree once turbo has exited via a Ctrl-C press?

@benscobie
Copy link

benscobie commented Jan 26, 2025

I'm having the same issue. Here are my process trees:

Before:
Image

On CTRL+C I managed to capture this (the PIDs are different than previous screenshot as it was a different run):
Image

All that is left in the tree afterwards is pwsh.exe:
Image

The other processes are now on their own without a parent:
Image

Let me know if you need me to run/try something else, I've been having this issue for a while so I'm keen to get it resolved.

@chris-olszewski chris-olszewski marked this as a duplicate of #9717 Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: windows Issues specifically reproducing on Windows kind: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants