Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More clearly delineate what belongs in FHIR resources and what is added/derived #24

Open
laurendukes opened this issue Jul 1, 2019 · 1 comment

Comments

@laurendukes
Copy link
Contributor

Right now our FHIR resource classes (Observation, RadiologyReport, etc.) are mostly what the FHIR DSTU2 spec says, but we've sprinkled in a few fields of our own. For better understandability and potential reuse, anything that we derive should get put in a superclass for those resources.

As part of this work, let's also look at all the fields we extract for each resource and ensure that we're handling them as the spec requires and not assuming that they come in one way or the other.

@hgui
Copy link
Contributor

hgui commented Aug 6, 2019

  1. Potentially create parent class of DomainResource for Observations and DiagnosticReport
  2. Extract requestID into a parent class to maintain clarity in FHIR standard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants