Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is batching appropriate (in this sink's current form)? #6

Open
cocowalla opened this issue Jul 3, 2017 · 1 comment
Open

Is batching appropriate (in this sink's current form)? #6

cocowalla opened this issue Jul 3, 2017 · 1 comment

Comments

@cocowalla
Copy link

I'm wondering if there is any benefit to this sink (in its current form) being an PeriodicBatchingSink?

As it stands, EmitBatch is simple sendin each message in the batch one-by-one, such that every message is sent using a new TCP connection.

I can see how this would make sense if #4 was implemented, as you would only flush at the end of every batch.
@vermeeca
Copy link
Owner

I think it probably makes more sense to go ahead and implement #4, but will keep this open in case it's not implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vermeeca @cocowalla