Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable no-wgl and include EGL DLLc in cargo packager #26

Closed
wusyong opened this issue Apr 17, 2024 · 5 comments
Closed

Enable no-wgl and include EGL DLLc in cargo packager #26

wusyong opened this issue Apr 17, 2024 · 5 comments

Comments

@wusyong
Copy link
Member

wusyong commented Apr 17, 2024

While cargo run on Windows works fine, it will need several DLLs to make the actual binary work.
In the final package, following DLL sources should be included:
https://github.com/servo/servo/blob/main/python/servo/build_commands.py#L365

@tensor-programming
Copy link
Member

tensor-programming commented Jun 1, 2024

Its mostly libgstreamer right or are there any other deps that are needed?

Nevermind, I see that there is also MSVC stuff involved. Ill take a look.

@wusyong
Copy link
Member Author

wusyong commented Jun 1, 2024

We will use cargo packager in the future. Probably worth looking into it to see if it has option to include custom dlls.

@tensor-programming
Copy link
Member

tensor-programming commented Jun 1, 2024

Ill check. My first go to was to just add a build.rs file that uses pkg-config but I am sure that cargo packager has its own stuff for that.

edit: I took a look and it looks as though they use WiX. It would be easier to have a build.rs rather than having to create a wix bootstrap program.

@wusyong wusyong changed the title Include missing DLLs on Windows Enable no-wgl and include EGL DLLc in cargo packager Jul 11, 2024
@wusyong
Copy link
Member Author

wusyong commented Jul 11, 2024

Rename the issue because it's WGL by default now. But since ANGLE is more stable, it's still better to enable it when we build with cargo packager in the future.

@pewsheen
Copy link
Collaborator

I'll handle this in #85

@wusyong wusyong closed this as completed Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants