Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up CI builds #60

Open
Mikopet opened this issue Jun 28, 2024 · 3 comments
Open

Speed up CI builds #60

Mikopet opened this issue Jun 28, 2024 · 3 comments

Comments

@Mikopet
Copy link
Member

Mikopet commented Jun 28, 2024

I noticed that the builds are generally slow. It could be speed up with some caching and better flow.

Example in the doc CI workflow

@wusyong
Copy link
Member

wusyong commented Jul 2, 2024

Doc CI workflow is also in separate pipeline which will have to build all over again apart from build.yml.
It would be great if it can build the doc in build.yml when it's pushed to main branch.

@Mikopet
Copy link
Member Author

Mikopet commented Jul 2, 2024

I was thinking I'm putting the whole doc generation in the doc repo, and detach it from the verso pushes.

There are multiple reasons to do it, one, is that stable rustdoc cannot make index page, that's an unstable nightly feature for some reason.

Perhaps it could generate new docs on a daily basis.

having separate work flow here is not really a problem, as it cached and kinda fast.

True, we could think about saving some build artifacts regarding cargo builds. Also perhaps own dockerfile to build verso (could make more sense than cache apt)

But also we want build matrix in the future, so that's perhaps not the best approach.

I will think about it later this week.

@wusyong
Copy link
Member

wusyong commented Aug 16, 2024

Maybe we can use rust cache as doc.yml does: https://github.com/versotile-org/verso/blob/main/.github/workflows/doc.yml#L25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants