Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce dataobjects and or builders for Vert.x Web handlers #2519

Open
Tracked by #610
tsegismont opened this issue Nov 21, 2023 · 1 comment · May be fixed by #2635
Open
Tracked by #610

Introduce dataobjects and or builders for Vert.x Web handlers #2519

tsegismont opened this issue Nov 21, 2023 · 1 comment · May be fixed by #2635
Assignees
Milestone

Comments

@tsegismont
Copy link
Contributor

Review Vert.x Web handlers and determine which ones have several data params or callbacks.

These handlers should be reworked to provide a builder and/or a dataobject to simplify implementation.

@tsegismont tsegismont added this to the 5.0.0 milestone Nov 21, 2023
@tsegismont tsegismont self-assigned this Nov 21, 2023
@tsegismont
Copy link
Contributor Author

tsegismont commented Dec 7, 2023

Analyzed existing handlers and found these are good candidates

  • CSPHandler
    • builder
  • CSRFHandler
    • data object
  • ErrorHandler skipped, just a couple of params only set in constructor
  • FaviconHandler skipped, single param only set in constructor
  • FormLoginHandler
    • data object
  • RedirectAuthHandler skipped, just a couple of params only set in constructor
  • TemplateHandler
    • remove setter, all params can be set in constructor
  • BodyHandler
    • data object
  • APIKeyHandler skipped, custom logic
  • AuthorizationHandler skipped
  • ChainAuthHandler
    • use a copy-on-write list for implementation (safer and more efficient)
  • CorsHandler skipped, custom logic
  • JWTAuthHandler skipped, custom logic
  • LoggerHandler skipped, just a couple of params only set in constructor
  • OAuth2AuthHandler skipped, custom logic
  • OtpAuthHandler skipped, custom logic
  • SessionHandler
    • data object
  • StaticHandler
    • data object
  • HealthCheckHandler skipped, not a good candidate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

1 participant