Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor command executor #485

Open
5 tasks
mvgijssel opened this issue Aug 31, 2023 · 0 comments
Open
5 tasks

Refactor command executor #485

mvgijssel opened this issue Aug 31, 2023 · 0 comments

Comments

@mvgijssel
Copy link
Member

mvgijssel commented Aug 31, 2023

This change introduced a regression to rules_task, that only a single defer kept working. The way defer currently works by wrapping a command with a piece of bash also feels a bit hacky, so maybe this is a good opportunity to rewrite the executor!

The executor should support

  • multiple defer statements
  • capture stdout to enable logging
  • parallel executions
  • capturing changes in env variables
  • merging asts of nested tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant