Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Video API: missing e.g. SDL_GetDisplays #43

Closed
flying-sheep opened this issue Nov 21, 2024 · 6 comments
Closed

Video API: missing e.g. SDL_GetDisplays #43

flying-sheep opened this issue Nov 21, 2024 · 6 comments

Comments

@flying-sheep
Copy link

can’t do anything with display IDs when one doesn’t know how many there are
revmischa added a commit that referenced this issue Nov 28, 2024
@revmischa
#43 GetDisplays
1c53924
@revmischa revmischa mentioned this issue Nov 28, 2024
Closed
@revmischa
Copy link
Collaborator

Want to try #43 ?

@flying-sheep
Copy link
Author

flying-sheep commented Nov 29, 2024 •
edited
Loading

you mean #45. sure! thanks!

I’ll be back from holidays on 9th, I can check after.

@revmischa
Copy link
Collaborator

Maybe it should return some sort of Display struct? #33

@flying-sheep
Copy link
Author

flying-sheep commented Dec 1, 2024 •
edited
Loading

E.g. using nutype

@CakesStuff CakesStuff mentioned this issue Feb 14, 2025
Merged
revmischa pushed a commit that referenced this issue Feb 16, 2025
@CakesStuff @nothankyou1
implement Display type #43 (#111)
f267d8f 
* implement Display type

* added remaining display events

---------

Co-authored-by: CakesStuff <[email protected]>
@revmischa
Copy link
Collaborator

@flying-sheep it's added!

@CakesStuff CakesStuff mentioned this issue Feb 16, 2025
Merged
revmischa added a commit that referenced this issue Feb 16, 2025
@CakesStuff @revmischa @nothankyou1
Merge getdisplays into master (#118)
f49cd12 
* #43 GetDisplays

* implement Display type #43 (#111)

* implement Display type

* added remaining display events

---------

Co-authored-by: CakesStuff <[email protected]>

* cargo fmt

---------

Co-authored-by: Mischa Spiegelmock <[email protected]>
Co-authored-by: CakesStuff <[email protected]>
@flying-sheep
Copy link
Author

Awesome! Closing this.

FYI: the docs for get_name still say

Get the name of the display at the index display_name.

without any index to be seen anywhere, but that’s just a nitpick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@revmischa @flying-sheep