Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty Header #246

Open
jlipski opened this issue Oct 23, 2014 · 0 comments
Open

Empty Header #246

jlipski opened this issue Oct 23, 2014 · 0 comments

Comments

@jlipski
Copy link
Contributor

jlipski commented Oct 23, 2014

What should be kasper behaviour when it receives an empty optional header, for example x-kasper-country?

I see two options:

  1. Return an error, for example unknown country
  2. Ignore such headers

Personally I opt for first more strict solution, but it can generate unexpected runtime errors. On the other hand ignoring them may cause confusion if empty header actually has a specific meaning.

In broader sense this question is about header validation - do we validate headers somehow, by checking for valid country code for example?

Related issue: https://viadeo.atlassian.net/browse/KPLAT-225

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants