From 937e6146dab8a45b1408bce8315a1ef1d1cf6e40 Mon Sep 17 00:00:00 2001 From: martha-johnston Date: Wed, 22 Jan 2025 23:32:59 +0100 Subject: [PATCH 1/3] add deprecation warnings to flutter sdk --- lib/src/robot/client.dart | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/src/robot/client.dart b/lib/src/robot/client.dart index 9506f9b55b..5b161349db 100644 --- a/lib/src/robot/client.dart +++ b/lib/src/robot/client.dart @@ -334,6 +334,8 @@ class RobotClient { return await _client.getCloudMetadata(rpb.GetCloudMetadataRequest()); } + /// Deprecated: use the Discovery Service APIs instead. + /// /// Discover components that the robot can connect to, given specific query metadata. /// /// ``` @@ -347,6 +349,7 @@ class RobotClient { ..model = sdkQuery.model ..extra = sdkQuery.extraStruct)); + log("RobotClient.discoverComponents is deprecated. It will be removed on March 10 2025. Use the DiscoveryService APIs instead."); final response = await _client.discoverComponents(request); return response.discovery.map((d) => Discovery.fromProto(d)).toList(); } From 15a9f7919aed517901107c13ed4d6ece939e3718 Mon Sep 17 00:00:00 2001 From: martha-johnston Date: Wed, 22 Jan 2025 23:37:39 +0100 Subject: [PATCH 2/3] also deprecate DiscoveryQuery --- lib/src/robot/client.dart | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/src/robot/client.dart b/lib/src/robot/client.dart index 5b161349db..7fd56fd68f 100644 --- a/lib/src/robot/client.dart +++ b/lib/src/robot/client.dart @@ -58,6 +58,8 @@ class RobotClientOptions { /// {@category Viam SDK} /// Represents a discovery query in the SDK to query for discoverable components. +/// +/// deprecated, remove on march 10th class DiscoveryQuery { final String subtype; final String model; From 21da7d5881d1367e7da4f74aa3604f2e2e5d8ca1 Mon Sep 17 00:00:00 2001 From: martha-johnston Date: Wed, 22 Jan 2025 23:45:11 +0100 Subject: [PATCH 3/3] fix warning log --- lib/src/robot/client.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/src/robot/client.dart b/lib/src/robot/client.dart index 7fd56fd68f..cc0a87deb5 100644 --- a/lib/src/robot/client.dart +++ b/lib/src/robot/client.dart @@ -351,7 +351,7 @@ class RobotClient { ..model = sdkQuery.model ..extra = sdkQuery.extraStruct)); - log("RobotClient.discoverComponents is deprecated. It will be removed on March 10 2025. Use the DiscoveryService APIs instead."); + _logger.w("RobotClient.discoverComponents is deprecated. It will be removed on March 10 2025. Use the DiscoveryService APIs instead."); final response = await _client.discoverComponents(request); return response.discovery.map((d) => Discovery.fromProto(d)).toList(); }