Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for self-hosted ntfy instances #8

Closed
amotl opened this issue Apr 21, 2023 · 4 comments
Closed

Support for self-hosted ntfy instances #8

amotl opened this issue Apr 21, 2023 · 4 comments

Comments

@amotl
Copy link
Contributor

amotl commented Apr 21, 2023

Dear Victor,

thanks a stack for conceiving and maintaining this excellent package.

Over at mqttwarn, we used to use Apprise to submit notifications to ntfy, which worked great. However, because we wanted to have better control within mqttwarn, we are adding a dedicated mqttwarn ntfy adapter now, see mqttwarn ntfy adapter documentation.

We had a look at your ntfy-wrapper package, but have not been able to use it right away, because it currently does not support self-hosted ntfy instances.

if dtype == "email":
h["Email"] = dest
url = "https://ntfy.sh/alerts"
else:
url = f"https://ntfy.sh/{dest}"

We think it would be so sweet if ntfy-wrapper could gain a feature to be able to define the ntfy HTTP API baseurl in some elegant way, in order to make using the library on self-hosted instances a first-citizen use case.

With kind regards,
Andreas.

/cc @binwiederhier

References

@vict0rsch
Copy link
Owner

Sure, that seems doable, let me have a look and I'll tag you on a PR

@vict0rsch
Copy link
Owner

@amotl can you checkout #9 and tell me if that works for you?

@amotl
Copy link
Contributor Author

amotl commented May 3, 2023

Thank you very much. I've validated the improvement on behalf of GH-10. It works well. 💯

image

@vict0rsch
Copy link
Owner

Merged #9 #10 and released 0.1.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants