From 287262599308f90a932b552d65a7d809d65c1893 Mon Sep 17 00:00:00 2001
From: Giuseppe Delle Cave <peppedellecave@live.it>
Date: Tue, 20 Feb 2024 22:02:48 +0100
Subject: [PATCH 1/3] Added logic to mark as required src/dst account based on
 transaction type

---
 src/components/Forms/TransactionSplitForm.tsx | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/components/Forms/TransactionSplitForm.tsx b/src/components/Forms/TransactionSplitForm.tsx
index e1756b2..b29538c 100644
--- a/src/components/Forms/TransactionSplitForm.tsx
+++ b/src/components/Forms/TransactionSplitForm.tsx
@@ -320,7 +320,7 @@ export default function TransactionSplitForm({
       />
 
       <AutocompleteField
-        isRequired
+        isRequired={'withdrawal' === formData.type || 'transfer' === formData.type }
         label={translate('transaction_form_sourceAccount_label')}
         placeholder={translate('transaction_form_sourceAccount_label')}
         value={formData.sourceName}
@@ -340,6 +340,7 @@ export default function TransactionSplitForm({
       />
 
       <AutocompleteField
+        isRequired={'deposit' === formData.type || 'transfer' === formData.type }
         label={translate('transaction_form_destinationAccount_label')}
         placeholder={translate('transaction_form_destinationAccount_label')}
         value={formData.destinationName}

From 13eb5864823f1aac5fabc391519c8a7c840cbc55 Mon Sep 17 00:00:00 2001
From: Giuseppe Delle Cave <peppedellecave@live.it>
Date: Wed, 21 Feb 2024 06:49:03 +0100
Subject: [PATCH 2/3] Refactoring source account isRequired check

Co-authored-by: victorbalssa <victor.balssa@gmail.com>
---
 src/components/Forms/TransactionSplitForm.tsx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/components/Forms/TransactionSplitForm.tsx b/src/components/Forms/TransactionSplitForm.tsx
index b29538c..834c405 100644
--- a/src/components/Forms/TransactionSplitForm.tsx
+++ b/src/components/Forms/TransactionSplitForm.tsx
@@ -320,7 +320,7 @@ export default function TransactionSplitForm({
       />
 
       <AutocompleteField
-        isRequired={'withdrawal' === formData.type || 'transfer' === formData.type }
+        isRequired={['withdrawal', 'transfer'].includes(formData.type)}
         label={translate('transaction_form_sourceAccount_label')}
         placeholder={translate('transaction_form_sourceAccount_label')}
         value={formData.sourceName}

From 0a6471bd905956bd9fa76c3386c7b2ee1f21137b Mon Sep 17 00:00:00 2001
From: Giuseppe Delle Cave <peppedellecave@live.it>
Date: Wed, 21 Feb 2024 06:49:20 +0100
Subject: [PATCH 3/3] Refactoring destination account isRequired check

Co-authored-by: victorbalssa <victor.balssa@gmail.com>
---
 src/components/Forms/TransactionSplitForm.tsx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/components/Forms/TransactionSplitForm.tsx b/src/components/Forms/TransactionSplitForm.tsx
index 834c405..3ebfe44 100644
--- a/src/components/Forms/TransactionSplitForm.tsx
+++ b/src/components/Forms/TransactionSplitForm.tsx
@@ -340,7 +340,7 @@ export default function TransactionSplitForm({
       />
 
       <AutocompleteField
-        isRequired={'deposit' === formData.type || 'transfer' === formData.type }
+        isRequired={['deposit', 'transfer'].includes(formData.type)}
         label={translate('transaction_form_destinationAccount_label')}
         placeholder={translate('transaction_form_destinationAccount_label')}
         value={formData.destinationName}