Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gui-v2 WASM crashes when changing the security profile from Unsecured to Weak #1881

Open
mpvader opened this issue Jan 29, 2025 · 2 comments · May be fixed by #1890
Open

gui-v2 WASM crashes when changing the security profile from Unsecured to Weak #1881

mpvader opened this issue Jan 29, 2025 · 2 comments · May be fixed by #1890
Assignees
Labels
bug Something isn't working medium_prio

Comments

@mpvader
Copy link
Contributor

mpvader commented Jan 29, 2025

And maybe when going from other profiles to other profiles as well. The setting does get changed effectively, so for the user its a simple matter of restarting the gui-v2 as a wasm. (clicking the link on VRM). He/she is not stuck.

Found while triaging a report here: https://victrondevelopment.slack.com/archives/C04CDB8KT0T/p1738139369132709.

This should be super simple to reproduce, I reproduced it in 5 seconds.

If easy to fix and backport, then lets do that. But if complicated, then OK for me to leave it as is and fix only in master cq. Venus OS v3.60.

@mpvader mpvader added bug Something isn't working high_prio High priority labels Jan 29, 2025
@blammit
Copy link
Contributor

blammit commented Jan 30, 2025

The Wasm app does have to reload when the security profile is changed, but it should not crash. I tested this with the latest main: if I connect with Wasm directly via MQTT on the local server, then the app reloads as expected after the profile change; if I connect via VRM portal, then the app quits after the profile change.

@mpvader mpvader added medium_prio and removed high_prio High priority labels Jan 30, 2025
@mpvader
Copy link
Contributor Author

mpvader commented Jan 30, 2025

Ok, then how about adding a notification that it will reload, as well as fixing the reload on vrm?

I’ll change the prio to medium

@blammit blammit pinned this issue Feb 1, 2025
@blammit blammit unpinned this issue Feb 1, 2025
DanielMcInnes added a commit that referenced this issue Feb 5, 2025
For wasm builds only. "Page will automatically reload in 5 seconds"
Part of #1881
DanielMcInnes added a commit that referenced this issue Feb 5, 2025
For wasm builds only. "Page will automatically reload in 5 seconds"
Part of #1881
DanielMcInnes added a commit that referenced this issue Feb 5, 2025
For wasm builds only. "Page will automatically reload in 5 seconds"
Part of #1881
DanielMcInnes added a commit that referenced this issue Feb 5, 2025
For wasm builds only. "Page will automatically reload in 5 seconds"
Part of #1881
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working medium_prio
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants