Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing @babel/cli, @babel/core and @babel/runtime dependencies #41

Open
rtritto opened this issue Sep 5, 2021 · 0 comments
Open

Missing @babel/cli, @babel/core and @babel/runtime dependencies #41

rtritto opened this issue Sep 5, 2021 · 0 comments

Comments

@rtritto
Copy link

rtritto commented Sep 5, 2021

Summary

After I install videojs-generate-rollup-config with yarn (berry version), I get dependency not found warnings in yarn log.

Respectively peerDeependencies:

  • @babel/core is of @rollup/plugin-babel; it should be added in dependencies
  • @babel/cli and @babel/runtime are of @videojs/babel-config; they should be added in dependencies

Versions

  • videojs-generate-rollup-config: 6.2.1

Steps to Reproduce

  1. yarn init -y
  2. yarn set version berry
  3. yarn add rollup videojs-generate-rollup-config
  4. See yarn log

Results

Actual

yarn log:

➤ YN0000: ┌ Resolution step
➤ YN0032: │ fsevents@npm:2.3.2: Implicit dependencies on node-gyp are discouraged
➤ YN0032: │ fsevents@npm:2.3.2: Implicit dependencies on node-gyp are discouraged
➤ YN0061: │ core-js@npm:2.6.12 is deprecated: core-js@<3.3 is no longer maintained and not recommended for usage due to the number of issues. Because of the V8 engine whims, feature detection in old core-js versions could cause a slowdown up to 100x even if nothing is polyfilled. Please, upgrade your dependencies to the actual version of core-js.
➤ YN0002: │ videojs-generate-rollup-config@npm:6.2.1 [79c3b] doesn't provide @babel/cli (p0f104), requested by @videojs/babel-config
➤ YN0002: │ videojs-generate-rollup-config@npm:6.2.1 [79c3b] doesn't provide @babel/core (p945e8), requested by @rollup/plugin-babel
➤ YN0002: │ videojs-generate-rollup-config@npm:6.2.1 [79c3b] doesn't provide @babel/runtime (pab663), requested by @videojs/babel-config
➤ YN0000: │ Some peer dependencies are incorrectly met; run yarn explain peer-requirements <hash> for details, where <hash> is the six-letter p-prefixed code
➤ YN0000: └ Completed
➤ YN0000: ┌ Fetch step
➤ YN0013: │ videojs-generate-rollup-config@npm:6.2.1 can't be found in the cache and will be fetched from the remote registry
➤ YN0013: │ which@npm:2.0.2 can't be found in the cache and will be fetched from the remote registry
➤ YN0013: │ wide-align@npm:1.1.3 can't be found in the cache and will be fetched from the remote registry
➤ YN0013: │ wrappy@npm:1.0.2 can't be found in the cache and will be fetched from the remote registry
➤ YN0013: │ yallist@npm:4.0.0 can't be found in the cache and will be fetched from the remote registry
➤ YN0000: └ Completed
➤ YN0000: ┌ Link step
➤ YN0007: │ core-js@npm:2.6.12 must be built because it never has been before or the last one failed
➤ YN0000: └ Completed
➤ YN0000: Done with warnings

Expect

No warning in yarn log.

Workaround

Add in .yarnrc.yml:

packageExtensions:
  "@videojs/babel-config@*":
    dependencies:
      "@babel/cli": "*"
      "@babel/runtime": "*"
  "@rollup/plugin-babel@*":
    dependencies:
      "@babel/core": "*"
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant