Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Three.js renderer options #258

Open
Smidgens opened this issue Dec 1, 2021 · 0 comments
Open

Three.js renderer options #258

Smidgens opened this issue Dec 1, 2021 · 0 comments

Comments

@Smidgens
Copy link

Smidgens commented Dec 1, 2021

It would be great if more options pertaining to the three.js WebGLRenderer were exposed in the videojs-vr config object for performance reasons.

Notable options include:

  • Anti-aliasing
  • Power Preference

Antialiasing for example seems to be enabled at all times:
https://github.com/videojs/videojs-vr/blob/main/src/plugin.js#L662

As far as I can tell, the renderer interface doesn't provide any setter functions to modify these properties post initialization, so even if you grab a reference to the renderer through the player (player.vr().renderer), there's still no way to tweak these options.

Even just having one property called customRendererOptions added to the videojs-vr options object would be sufficient, to allow the user to override any property at his own risk, and perhaps free the maintainers of this project from needing to maintain explicit parity with the three.js interface.


Edit: See PR #259

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant