Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add crawler test to docs and ci #76

Open
vinayak-mehta opened this issue Nov 5, 2019 · 1 comment
Open

Add crawler test to docs and ci #76

vinayak-mehta opened this issue Nov 5, 2019 · 1 comment
Labels
documentation enhancement New feature or request

Comments

@vinayak-mehta
Copy link
Owner

vinayak-mehta commented Nov 5, 2019 •
edited
Loading

Doc:
"Before raising a PR with a crawler, run it with python -m crawlers CreepyCrawler to see if it works.".

CI:
A PR with a crawler should start a CI job which tries to run for one event.
@vinayak-mehta vinayak-mehta added enhancement New feature or request documentation labels Nov 5, 2019
@vinayak-mehta vinayak-mehta changed the title Add crawler test docs and ci Add crawler test to docs and ci Nov 5, 2019
@vinayak-mehta
Copy link
Owner Author

vinayak-mehta commented Nov 5, 2019 •
edited
Loading

CI job should also output the schema validations that were failed while running the crawler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vinayak-mehta