Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use url.PathEscape() instead of having dataurl.Escape #5

Open
MagicalTux opened this issue May 28, 2021 · 0 comments · May be fixed by #6
Open

Use url.PathEscape() instead of having dataurl.Escape #5

MagicalTux opened this issue May 28, 2021 · 0 comments · May be fixed by #6

Comments

@MagicalTux
Copy link

The only difference is that uri.PathEscape will also escape ( and ) which while not required is acceptable according to rfc2396. Data uri tend to be used in places where escaping ()s can be useful (css, etc) and as such, golang's implementation makes more sense.
MagicalTux added a commit to MagicalTux/dataurl that referenced this issue May 28, 2021
@MagicalTux
fix vincent-petithory#5 by using url methods instead of re-implementi…
d28ab02 
…ng these
@MagicalTux MagicalTux linked a pull request May 28, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use net/url escape methods instead of re-implementing MagicalTux/dataurl
1 participant
@MagicalTux