Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear-up all calls to packSCMP #192

Closed
1 of 3 tasks
jcp19 opened this issue Mar 9, 2023 · 1 comment · Fixed by #243
Closed
1 of 3 tasks

Clear-up all calls to packSCMP #192

jcp19 opened this issue Mar 9, 2023 · 1 comment · Fixed by #243

Comments

@jcp19
Copy link
Contributor

jcp19 commented Mar 9, 2023

For now, I can provide an ideal spec, which can later be confirmed by the PR from @Dspil

TODO:

  • come up with ideal spec for packSCMP and verify the entire codebase accordingly @jcp19
  • verify packSCMP with the contract up until the call to prepareSCMP @jcp19
  • verify the remainder of prepareSCMP such that packSCMP verifies @Dspil
@jcp19
Copy link
Contributor Author

jcp19 commented Jan 22, 2024

Note to self:
The ideal spec should take full perms for the ub, should return most of it (1 - R15) as well as a wand from the R15 address if it aliases to R15 of the ub, otherwise should give the ub (R15) already. It should also satisfy p.d.validResult. I will take care of this after all open tasks in #240 are handled

@jcp19 jcp19 linked a pull request Jan 26, 2024 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant