Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize support for friend clauses #830

Open
1 of 2 tasks
jcp19 opened this issue Jan 29, 2025 · 0 comments
Open
1 of 2 tasks

Stabilize support for friend clauses #830

jcp19 opened this issue Jan 29, 2025 · 0 comments

Comments

@jcp19
Copy link
Contributor

jcp19 commented Jan 29, 2025

Friend clauses have been introduced in #810, but the heuristics used to match the packages mentioned in the friends clauses with the packages that receive the resources are still very finicky and config dependent, and they do not work in our test suit (although they work when running outside the test suite).

This issue keeps track of two tasks that need to be done before this feature is stable:

  • make the heuristics to match the packages independent of the config
  • add a check that friendsClauses do not create loops in forwarding resources (this is prevented by the checks for that import relations are acyclical - for a package to send packages to itself, it must be able to import itself and state permission preconditions. that is not possible, as cyclical imports are rejected by the compiler. This generalizes to chains of imports with more than one package.
@jcp19 jcp19 mentioned this issue Jan 30, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant