Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

player detail pane display issues #707

Closed
cpritcha opened this issue Aug 24, 2021 · 1 comment
Closed

player detail pane display issues #707

cpritcha opened this issue Aug 24, 2021 · 1 comment

Comments

@cpritcha
Copy link
Contributor

cpritcha commented Aug 24, 2021 •
edited
Loading

image

  • not displaying accomplishment costs
  • science is rendered to the side (and there is a horizontal scroll bar instead of vertical)
@alee alee mentioned this issue Aug 24, 2021
Closed
@alee alee changed the title player detail pane showing rendering issues player detail pane display issues Aug 24, 2021
cpritcha added a commit that referenced this issue Aug 25, 2021
@cpritcha @alee
feat: bootstrapify player detail modals
232d881 
Related to #707

Co-Authored-By: chrstngyn <[email protected]>
Co-Authored-By: Allen Lee <[email protected]>
chrstngyn pushed a commit to chrstngyn/port-of-mars that referenced this issue Aug 26, 2021
@cpritcha @alee
feat: bootstrapify player detail modals
be47c34 
Related to virtualcommons#707

Co-Authored-By: chrstngyn <[email protected]>
Co-Authored-By: Allen Lee <[email protected]>
cpritcha added a commit that referenced this issue Sep 2, 2021
@cpritcha @alee
feat: bootstrapify player detail modals
ad121b8 
Related to #707

Co-Authored-By: chrstngyn <[email protected]>
Co-Authored-By: Allen Lee <[email protected]>
chrstngyn pushed a commit to chrstngyn/port-of-mars that referenced this issue Sep 7, 2021
@cpritcha @alee
feat: bootstrapify player detail modals
734e3b7 
Related to virtualcommons#707

Co-Authored-By: chrstngyn <[email protected]>
Co-Authored-By: Allen Lee <[email protected]>
@alee
Copy link
Member

alee commented Nov 22, 2021

fixed

TODO: consider moving accomplishments pane up to take the available empty space next to the player avatar since that list is typically longer #759

@alee alee closed this as completed Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alee @cpritcha