Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default maxYear to the current year, not 2015 #54

Open
colbywhite opened this issue Jan 6, 2016 · 1 comment
Open

Default maxYear to the current year, not 2015 #54

colbywhite opened this issue Jan 6, 2016 · 1 comment

Comments

@colbywhite
Copy link

For an example, take a look at the demo page. None of those dropdowns allow you to select 2016 since the default max is 2015.

The default should be whatever the current year is. The trick to that will be dealing with timezones. The current year will be different depending on browser.

@vcarel
Copy link

vcarel commented Jan 21, 2016

+1
I'm lazy to make a pull-request, but the solution is pretty simple:

In src/combodate.js, line 513, replace:
maxYear: 2015
by:
maxYear: (new Date()).getFullYear()

colbywhite added a commit to colbywhite/combodate that referenced this issue Jan 23, 2016
credit to @vcarel. I incorrectly thought the timezone would make
this change harder. but it's simple.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants