Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Price format in readme's example is misleading #21

Open
smknstd opened this issue Sep 8, 2021 · 0 comments
Open

Price format in readme's example is misleading #21

smknstd opened this issue Sep 8, 2021 · 0 comments

Comments

@smknstd
Copy link

smknstd commented Sep 8, 2021 •
edited
Loading

In README.md, shipping price example is misleading as it looks like an amount in cents:

$shipping->setPrice('1300 USD');

It expects price in ISO 4217 format + max value is 1000 as seen here https://support.google.com/merchants/answer/6324484 so example probably should be:

$shipping->setPrice('13.50 USD');

same with product price https://support.google.com/merchants/answer/6324371, it could include a comment to clarify:

$item->setPrice("{$product->price} USD"); //ex: "89.90 USD"

What do you think ?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@smknstd