Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VReplication SwitchTraffic: for a dry run check if sequences need to be updated #17842

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Address review comments

7dfa644
Select commit
Loading
Failed to load commit list.
Open

VReplication SwitchTraffic: for a dry run check if sequences need to be updated #17842

Address review comments
7dfa644
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 26, 2025 in 1s

67.46% (+0.00%) compared to 2118bc3

View this Pull Request on Codecov

67.46% (+0.00%) compared to 2118bc3

Details

Codecov Report

Attention: Patch coverage is 67.99242% with 169 lines in your changes missing coverage. Please review.

Project coverage is 67.46%. Comparing base (2118bc3) to head (7dfa644).
Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/vtctl/workflow/sequences.go 68.16% 163 Missing ⚠️
go/vt/vtctl/workflow/switcher_dry_run.go 62.50% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main   #17842    +/-   ##
========================================
  Coverage   67.45%   67.46%            
========================================
  Files        1592     1595     +3     
  Lines      258167   259147   +980     
========================================
+ Hits       174143   174828   +685     
- Misses      84024    84319   +295     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.