Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List latest Wine engine releases in when adding new engines to Winery #36

Open
marnovo opened this issue Jul 1, 2018 · 11 comments
Open

Comments

@marnovo
Copy link
Contributor

marnovo commented Jul 1, 2018

Feature request:

Wineskin Winery should automatically list the latest Wine engines available for macOS in the list of available engines whenever you are adding a new Wine engine to the Wineskin Winery application.

Thank you for supporting this project.

@marnovo marnovo changed the title List latest Wine releases in when adding new engines to Winery List latest Wine engine releases in when adding new engines to Winery Jul 1, 2018
@Gcenx
Copy link
Collaborator

Gcenx commented Jul 1, 2018

When the project is ready it will have all usable engines available via Winery.app

But that also requires hosting & hosting costs for said engine files the real release can not do what I'm currently doing with my unofficial update since Github limits to 1GB of space.

@marnovo
Copy link
Contributor Author

marnovo commented Jul 2, 2018

@Gcenx thanks for the prompt reply! Couldn't you rely on the listing/hosting from the WINE project itself?

By the way, I have a small tutorial on how to add a new engine to the list manually.

@Gcenx
Copy link
Collaborator

Gcenx commented Jul 2, 2018

@marnovo there is already a tool to package the wine versions into engines under the Wineskin Community repot.
It's based on your code that you linked btw

I guess technically it could just download Wine and repack it directly but that does not help for things like WineCX engines and keeping support for OSX10.6, so prepackaged engines would be best in those cases

@Gcenx
Copy link
Collaborator

Gcenx commented Jul 7, 2018

@vitor251093 I keep thinking about the idea of Winery downloading the pre-build Wine builds and just packing them into Engines and only hosting things like WineCX engines?

@chrisballinger
Copy link
Collaborator

chrisballinger commented Jul 7, 2018 via email

@vitor251093
Copy link
Owner

It makes sense for me as well.

Although, since we already very close to a stable version at the moment, I think we can leave that for the second version ;)

By the way, talking about versioning, @chrisballinger do you have any recommended versioning system?

@chrisballinger
Copy link
Collaborator

I like using something like semver: https://semver.org/

major.minor.patch

@marnovo
Copy link
Contributor Author

marnovo commented Jul 8, 2018

+1 to semver.org (not that you asked me, anyway) :)

@vitor251093
Copy link
Owner

vitor251093 commented Jul 8, 2018

Nice :D

Considering that the minor and the patch versions require the update to be backwards-compatible, and if we want to adopt it for good, I think the best way to start the first release would be with Wineskin Winery 2.0 (prior official version was 1.7) and Wineskin App 3.0 (prior official version was 2.6.2).

Everyone agrees with that?

@marnovo lol, sorry for almost ignoring you in your own issue xD

@Gcenx
Copy link
Collaborator

Gcenx commented Jul 8, 2018

Agreed

@chrisballinger
Copy link
Collaborator

chrisballinger commented Jul 8, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants