Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code review comments on 2nd Feb on college cloud post processing #39

Open
ksripathi opened this issue Mar 7, 2017 · 3 comments
Open
Assignees
Labels

Comments

@ksripathi
Copy link
Contributor

No description provided.

@ksripathi ksripathi self-assigned this Mar 7, 2017
@ksripathi
Copy link
Contributor Author

ksripathi commented Mar 7, 2017

Review comments on college cloud documentation :

  1. Issue to be created on how flask wsgi issue got resolved with college registration form
  2. Requirements to be modified as follows
    • Create a manual for provisioning and configuring college cloud
    • Facilitate collection of logs and analytics on college cloud
  • Facilitate college cloud registration
  • Provide a mechanism to push analytics to vlead central server
  1. Design section should be fixed
  • Broken image links to be fixed
  • Against each requirement design should be captured
  1. Post process of college cloud requirements
  • Collection of analytics .tar.gz
  • RESTfull APIs to be implemented to push the analytics to vlead central server
  • Command line tool to post process the data (needs to elaborate more)
  1. Post process script should be explained more like a story where & how it data will flow before put it into elastic search database

  2. In docs 'up' links are broken

  3. Generic function to check college details needs to be written

  4. Link documentation b/w feedback and college cloud since all post processing apis are implemented as part of feedback service this gives lot of confusion so better explain more wherever required as needed. (Done)

@ksripathi
Copy link
Contributor Author

ksripathi commented Mar 7, 2017

  1. Write separate module for dumping historic feedback data to elastic search database and set a cronjob for other module which will take regular feedback dump on every mid night. (Done)
  2. Attach more explanation with implementation as design (Done)

@ksripathi
Copy link
Contributor Author

Incorporated review comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant