Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a "skip when fail" flag for a unstable convention server #155

Open
mhoshi-vm opened this issue Jul 6, 2022 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@mhoshi-vm
Copy link

Describe the feature request

While exploring the creation of custom convention service, currently the convention controller performs very strict checks and fails the entire podintent when even 1 convention server fails to respond with a PodConventionContext (with Status and AppliedStatus included).

This strictness becomes a barrier for deploying / testing convention servers, as it affects all cartographer workloads in the cluster to be prevented to proceed.

While ideally the convention server should always be stable, it will help developing conventions if we can relax this checking by adding a flag to skip the convention server, if it fails to respond with the correct output.

Is your feature request related to a problem? Please describe

Describe alternatives you've considered

Additional context

@mhoshi-vm mhoshi-vm added the enhancement New feature or request label Jul 6, 2022
@scothis
Copy link
Contributor

scothis commented Jul 6, 2022

a barrier for deploying

If using a tool that can order the creation of resource (like kapp) it can be useful to hold the creation of the ClusterPodConvention until the webhook service is ready.

it will help developing conventions

To take the contrarian position, when developing a convention it's even more important to see errors exposed as hard failures. I want to have confidence that my code is working, or not, and never have ambiguity.


If a developer in their own environment really wants this setting, I could see it being available as a cluster wide config value. I don't see introducing this capability on a convention by convention basis, as it's too easy for a dev resource configuration to slip into production. (we don't offer a way to skip TLS verification for the same reason).

@seagomezar seagomezar added this to the 0.4.2 milestone Apr 3, 2023
@rashedkvm rashedkvm removed this from the 0.4.2 milestone Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants