Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use go 1.19's soft memory limit when it is released #1103

Open
enj opened this issue Mar 31, 2022 · 3 comments · May be fixed by #2124
Open

Use go 1.19's soft memory limit when it is released #1103

enj opened this issue Mar 31, 2022 · 3 comments · May be fixed by #2124
Assignees
Labels
chore Not a bug or an enhancement, but still a work item state/started Someone is working on it currently

Comments

@enj
Copy link
Contributor

enj commented Mar 31, 2022

golang/go#48409 is expected to release in go 1.19 and will allow us to do something like deployment.spec.template.spec.containers[0] for the supervisor, concierge and kube-cert-agent deployments:

      env:
       # reduce OOM likelyhood
       - name: GOMEMLIMIT
          valueFrom:
            resourceFieldRef:
              containerName: #@ defaultResourceName()
              resource: limits.memory
@pinniped-ci-bot pinniped-ci-bot added enhancement New feature or request priority/undecided Not yet prioritized chore Not a bug or an enhancement, but still a work item and removed enhancement New feature or request labels Apr 11, 2022
@joshuatcasey
Copy link
Member

@joshuatcasey
Copy link
Member

Note that containerName is optional for environment variables: https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.30/#resourcefieldselector-v1-core

@joshuatcasey
Copy link
Member

I've pushed this to a branch jtc/use-soft-memory-limit-1103 but will hold off on a PR temporarily as we've got other PRs using up the pipeline.

@joshuatcasey joshuatcasey self-assigned this Jul 26, 2024
@joshuatcasey joshuatcasey added state/started Someone is working on it currently and removed priority/undecided Not yet prioritized labels Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Not a bug or an enhancement, but still a work item state/started Someone is working on it currently
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

3 participants