-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is Greek to ASCII correct? #4
Comments
OK.. need to understand what is the purpose of this lib. For instance convert Greek characters to what we Greeks call Greeklish (writing Greek using English characters in order to avoid language switching from keyboard) Or you want to convert Greek characters to something meaningful? Something that could be used to Road Signs for instance. Example let's use the word according to your lib it will be
Instead on a Road Sign you will in Greece you will see Same goes for other letters |
Maybe we can add both ways, because you can choose one and so it's more useful for different situations. For example there is a similar issue for "ru" (#3 (comment)). Maybe we can also add e.g. "el_greeklish". Only a idea, what do you think? |
@gmponos I have separated "greek" and "greeklish", can you please re-review the changes, thanks. |
@voku as a native speaker I think the greeklish mappings are not very accurate. For example Also:
|
@sebdesign Thanks for the update. Can you please take a look at this fix: abfac74 |
@voku I'll take a look later tonight! |
Example: Is this correct?
"Ελληνικό αλφάβητο" -> "Ellhniko alfabhto"
Can a native speaker, please check the character-replacement, thanks.
https://github.com/voku/portable-ascii/blob/master/src/voku/helper/data/ascii_by_languages.php#L4
The text was updated successfully, but these errors were encountered: