Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

directly compared the variable with zero may cause bugs #2

Open
eteced opened this issue Apr 29, 2019 · 0 comments
Open

directly compared the variable with zero may cause bugs #2

eteced opened this issue Apr 29, 2019 · 0 comments

Comments

@eteced
Copy link

eteced commented Apr 29, 2019

alpha_l = 0.0 if det_C0_C1 == 0 else det_X_C1 / det_C0_C1

Try to fit this bad case:
points: [[1605.99181736 1433.82668586]
[1608.81290918 1436.66242932]
[1612.4412136 1438.2910418 ]]
leftTangent:[0.65773635 0.75324822] rightTangent:[-0.71222538 -0.70195086]

I think changed to fabs(_) < 1e-3 is better, and would solve the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant