Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support batches without a topic #382

Open
evanp opened this issue Apr 27, 2018 · 1 comment
Open

Support batches without a topic #382

evanp opened this issue Apr 27, 2018 · 1 comment
Labels
bug The software doesn't do what we say it does

Comments

@evanp
Copy link
Contributor

evanp commented Apr 27, 2018 •
edited
Loading

Should we support batches without a "topic" member? Version 1.x throws an error at constructor time if there's no topic. Version 0.x just runs the tests.
@evanp evanp added the question label Apr 27, 2018
@evanp
Copy link
Contributor Author

evanp commented May 7, 2018

I think we could handle this as just having undefined as the topic.

@evanp evanp changed the title Support batches without a topic? Support batches without a topic May 7, 2018
@evanp evanp added bug The software doesn't do what we say it does and removed question labels May 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug The software doesn't do what we say it does
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@evanp