Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--supress-output doesn't work on NodeJS 8.x and above #399

Open
evanp opened this issue May 15, 2018 · 2 comments
Open

--supress-output doesn't work on NodeJS 8.x and above #399

evanp opened this issue May 15, 2018 · 2 comments
Assignees
@evanp
Labels
bug The software doesn't do what we say it does

Comments

@evanp
Copy link
Contributor

evanp commented May 15, 2018

Tests fail for supress output if NodeJS is 8.x or above. Seems to be a difference in the way the console is initialized; it grabs the process.stdout before we can replace it with a dummy.

This keeps tests for v0.8.x from working for later versions.
@evanp evanp added the bug The software doesn't do what we say it does label May 15, 2018
@evanp evanp self-assigned this May 15, 2018
@JerrySievert
Copy link

perhaps grab console._stdout?

@evanp
Copy link
Contributor Author

evanp commented May 22, 2018

It might also be possible to overwrite console

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evanp evanp

Labels
bug The software doesn't do what we say it does
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@evanp @JerrySievert