Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial #6 general comments #21

Open
rdgao opened this issue Nov 20, 2018 · 3 comments
Open

Tutorial #6 general comments #21

rdgao opened this issue Nov 20, 2018 · 3 comments

Comments

@rdgao
Copy link

rdgao commented Nov 20, 2018

No description provided.

@rdgao
Copy link
Author

rdgao commented Nov 20, 2018

  • any reason this notebook has a different convention in that the code is hidden? This is really nice and clean (I like it personally), but depending on whether showing code is a priority, it might be too sparse?
  • "General noise is a signal that is largely formed through a stochasitc process" is a little confusing. I would just say here that "we define noise to be the output (or result) of a stochastic process"
  • I would not point to the law of large numbers as the "reason" for why total power is equal in two frequency bands for white noise. If the point is that summing across bands will give a more stable estimate of power at any frequency, then yes, it's correct. But if the point is that a white noise spectrum has equal power at all frequencies, then there are other ways of explaining that, e.g., no prefered timescale of change in the signal
  • a note before the first pair of FFT plots clarifying that left is linear power and right is log power would be helpful to orient the reader. I think this is done later in the pink noise section.
  • in general, one thing I find useful is to keep the same "type" of plots the same size, and the consistency cues the reader as to what they're looking at without needing to look at the axis. Having the welch PSD plot long like the time series plot suggests that they are similar, though really it's more analogous to the FT plots.
  • brown noise has a particular relationship to white noise, in that brown noise is the cumulative sum (or integral) of white noise.

@lakimenon
Copy link

  • stochastic misspelled as "stochasitc" in the first line

@meyhaa
Copy link

meyhaa commented May 8, 2019

  • Introduction
    • Format of introduction is different from other tutorials. Move the introduction blurb before the default imports.
    • Include a more detailed introduction with a list of the goals/ the purpose of this tutorial.
  • White Noise - Time Domain
    • Label axes in graph
  • White Noise - Frequency Domain
    • fourier transform misspelled as "transfrom"
    • Welch plot is introduced/mentioned. Is this a term I should already know? Would appreciate some additional info/external reference on what welch plots are/why they’re used in this tutorial.
      • [In block 30]: more comments in the code
      • Not sure what fs_white, ps_white are/
  • Pink Noise - Time Domain
    • Label axes of time series graph
  • Brown Noise - Time Domain
    • Label axes of time series graph
  • Brown Noise - Frequency Domain
    • Would appreciate more info on how the β value affects slope in the log-log plot and how that relates to the purpose of the tutorial as a whole.

Potential Key Terms for Glossary (list for you to narrow down/edit):
General Noise
Stochastic Process
Power Law Noises
Colored Noise
White Noise
Welch Plot
Pink Noise
Brown Noise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants